Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed a warning related to import of rmsapi #268

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Removed a warning related to import of rmsapi #268

merged 1 commit into from
Jan 2, 2025

Conversation

oddvarlia
Copy link
Contributor

Removed a warning related to import of rmsapi (roxapi)

@oddvarlia oddvarlia force-pushed the remove_warning_message branch from 368ca56 to 69948b5 Compare January 2, 2025 10:07
@oddvarlia oddvarlia requested a review from tnatt January 2, 2025 10:09
tnatt
tnatt requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the imports in RMS (both 14.2 and 13.2) and it seems there still is an issue here. I added a suggestion for you consideration 🙂

src/fmu/tools/rms/generate_petro_jobs_for_field_update.py Show resolved Hide resolved
@oddvarlia oddvarlia force-pushed the remove_warning_message branch 2 times, most recently from b9897aa to 4b826f0 Compare January 2, 2025 12:09
@oddvarlia oddvarlia force-pushed the remove_warning_message branch 2 times, most recently from faa7425 to bba0379 Compare January 2, 2025 12:49
@oddvarlia oddvarlia requested a review from tnatt January 2, 2025 12:59
@oddvarlia oddvarlia force-pushed the remove_warning_message branch from bba0379 to d797e2b Compare January 2, 2025 13:28
tnatt
tnatt approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oddvarlia oddvarlia merged commit 39c3f3f into equinor:main Jan 2, 2025
14 checks passed
tnatt pushed a commit to tnatt/fmu-tools that referenced this pull request Jan 2, 2025
@oddvarlia @tnatt
Removed warning (equinor#268)
46bbd12
tnatt pushed a commit that referenced this pull request Jan 3, 2025
@oddvarlia @tnatt
Removed warning (#268)
78466a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnatt tnatt tnatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oddvarlia @tnatt