Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Apply more linting rules #954

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jan 6, 2025

This implements some additional linting rules and prepares a few others. It also adds the --cov --cov-report term-missing coverage report to be emitted at the end of test runs, which may be noisier but still useful to see. The test runs install the package with -e now so that the code lines missing test coverage are visible.

@mferrera mferrera marked this pull request as ready for review January 6, 2025 07:45
@mferrera mferrera force-pushed the update-ruff-checks branch from de2d798 to b5ea81c Compare January 6, 2025 07:47
@mferrera mferrera requested review from tnatt and joargr January 6, 2025 07:54
@mferrera mferrera force-pushed the update-ruff-checks branch from b5ea81c to 15a618a Compare January 6, 2025 07:55
@mferrera mferrera self-assigned this Jan 6, 2025
This implements some additional linting rules and prepares a few others.
It also adds the `--cov --cov-report term-missing` coverage report to be
emitted at the end of test runs, which may be noisier but still useful
to see. The test runs install the package with `-e` now so that the code
lines missing test coverage are visible.
@mferrera mferrera force-pushed the update-ruff-checks branch from 15a618a to 7a89fc8 Compare January 6, 2025 08:01
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support these changes 👍 the style improvements looks good!

@mferrera mferrera merged commit f5dc107 into equinor:main Jan 6, 2025
16 checks passed
@mferrera mferrera deleted the update-ruff-checks branch January 6, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants