MAINT: Template schema version and add dev schema url #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
adjust-schema-version
branch
from
3a28d6d to
2cf5358
Compare
slangeveld
reviewed
Dec 30, 2024
| @@ -268,7 +270,7 @@ def generate( | |||
| ) -> dict[str, Any]: | |||
| json_schema = super().generate(schema, mode=mode) | |||
| json_schema["$schema"] = self.schema_dialect | |||
| json_schema["$id"] = "fmu_results.json" | |||
| json_schema["$id"] = FmuResultsSchema.url() | |||
There was a problem hiding this comment.
Is it correct that the id is set to a url?
There was a problem hiding this comment.
For a top-level schema, yep: ref.. Not the best naming...
Incidentally, this value is overwritten here anyway:
But I'm hoping to make this a little more explicit in the code and eventually remove this shell script patch
slangeveld
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #909
Opens #907
A little pre-work for setting up the inplace volumes product schema checking + schema versioning