Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove AnyProduct discriminator mapping #935

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mferrera
Copy link
Collaborator

Resolves #933

@mferrera mferrera self-assigned this Dec 19, 2024
@mferrera mferrera requested a review from tnatt December 19, 2024 08:41
@mferrera mferrera marked this pull request as ready for review December 19, 2024 08:41
@mferrera mferrera force-pushed the remove-anyproduct-disc-mapping branch from a5aae49 to 331197a Compare December 19, 2024 08:50
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get a test in here! Otherwise this will go under my radar again 😄

@mferrera
Copy link
Collaborator Author

Mine as well. We could set up a function to recursively go through and purge these when dumping, but for the moment it might be best to be explicit. What do you think?

@mferrera mferrera merged commit b3b4121 into equinor:main Dec 19, 2024
15 checks passed
@mferrera mferrera deleted the remove-anyproduct-disc-mapping branch December 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AnyProduct discriminator mapping from exported schema
2 participants