ENH: validate inplace volumes with Pydantic #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
validate-invols-at-export
branch
from
8ed7dfd to
e31d241
Compare
tnatt
approved these changes
Dec 20, 2024
| @@ -172,7 +173,7 @@ def _transform_and_add_fluid_column_to_table( | |||
| ) | |||
|
|
|||
| # add the fluid as column entry instead | |||
| fluid_table[_enums.InplaceVolumes.FLUID_COLUMN] = fluid | |||
| fluid_table[_enums.InplaceVolumes.FLUID_COLUMN.value] = fluid | |||
There was a problem hiding this comment.
enums drive me crazy sometimes..
There was a problem hiding this comment.
Funny thing is that it worked just fine. Terrible thing is that it worked just fine 😅
mferrera
force-pushed
the
validate-invols-at-export
branch
from
e31d241 to
b3af680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #896
Fixed a semi-bug with setting the dataframe FLUID column as well.