Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add exportvolumetrics fixture #921

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Dec 16, 2024

For testing functionaliy related to _ExportVolumetricsRMS we have to duplicate a lot of code in every test in order to have a mock of the rmsapi modules and mocking the return value of the _get_table_with_volumes function to avoid the instance creation failing.

This PR gathers this into a fixture that can be used in the tests instead. This will be useful as the tests for this class are still being added.

@tnatt tnatt requested a review from mferrera December 16, 2024 07:55
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tnatt tnatt merged commit 8ebbbb4 into equinor:main Dec 16, 2024
15 checks passed
tnatt added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants