-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add data.product to schema #904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
commented
Dec 9, 2024
tnatt
force-pushed
the
add_product_model
branch
2 times, most recently
from
December 18, 2024 12:35
a6cf4c4
to
a4a96d9
Compare
tnatt
force-pushed
the
add_product_model
branch
from
December 18, 2024 12:56
a4a96d9
to
f34f559
Compare
mferrera
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 8, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 8, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 8, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
mferrera
pushed a commit
to mferrera/fmu-dataio
that referenced
this pull request
Jan 14, 2025
slangeveld
pushed a commit
to slangeveld/fmu-dataio
that referenced
this pull request
Jan 22, 2025
slangeveld
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that closes #876
Tests will be added once we add functionality to set the
product
in the metadata