Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add data.product to schema #904

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Dec 9, 2024

PR that closes #876

Tests will be added once we add functionality to set the product in the metadata

@tnatt tnatt marked this pull request as draft December 9, 2024 09:18
@tnatt tnatt force-pushed the add_product_model branch 2 times, most recently from a6cf4c4 to a4a96d9 Compare December 18, 2024 12:35
@tnatt tnatt force-pushed the add_product_model branch from a4a96d9 to f34f559 Compare December 18, 2024 12:56
@tnatt tnatt marked this pull request as ready for review December 18, 2024 12:56
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@tnatt tnatt merged commit 704f5cb into equinor:main Dec 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a minimal definition for the product key in metadata
3 participants