ENH: Add ert simulation mode to object metadata #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
add-simulation-mode
branch
2 times, most recently
from
8644c6f to
95c47f1
Compare
The simulation mode should allow contextual inference about the type of ensemble this data is derived from.
mferrera
force-pushed
the
add-simulation-mode
branch
from
95c47f1 to
d9ce6ec
Compare
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
reviewed
Nov 6, 2024
jcrivenaes
approved these changes
Nov 6, 2024
tnatt
approved these changes
Nov 12, 2024
| @@ -406,3 +407,20 @@ def test_fmuprovider_workflow_reference(fmurun_w_casemetadata, globalconfig2): | |||
| pydantic.ValidationError, match="Input should be a valid string" | |||
| ): | |||
| FmuProvider(model=GLOBAL_CONFIG_MODEL, workflow=123.4).get_metadata() | |||
|
|
|||
|
|
|||
| def test_ert_simulation_modes_one_to_one() -> None: | |||
There was a problem hiding this comment.
I was getting ready to make a comment about them coming out of sync 😅 happy to find this test here at the bottom 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #804
Resolves #690 (more or less)
Resolves #263
The simulation mode should allow contextual inference about the type of ensemble this data is derived from.