-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff as linter #405
Use ruff as linter #405
Conversation
@@ -138,7 +140,7 @@ def export_file(obj, filename, extension, flag=None): | |||
elif extension == ".roff" and isinstance(obj, (xtgeo.Grid, xtgeo.GridProperty)): | |||
obj.to_file(filename, fformat="roff") | |||
elif extension == ".csv" and isinstance(obj, pd.DataFrame): | |||
includeindex = True if flag == "include_index" else False | |||
includeindex = flag == "include_index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider comment about example, otherwise LGTM 👍
cfg = {} | ||
|
||
cfg = dict() | ||
cfg = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future PR could probably remove this duplication
Merge after: #404