Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set inspection id from isar response #1874

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Set inspection id from isar response #1874

merged 2 commits into from
Dec 13, 2024

Conversation

tsundvoll
Copy link
Contributor

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@tsundvoll tsundvoll force-pushed the set-ids-from-isar-mission branch 2 times, most recently from 467b25d to 716ba89 Compare December 12, 2024 14:36
@tsundvoll tsundvoll force-pushed the set-ids-from-isar-mission branch from 716ba89 to 53c26c5 Compare December 13, 2024 08:18
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Dec 13, 2024
@oysand oysand mentioned this pull request Dec 13, 2024
Closed
10 tasks
oysand
oysand approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsundvoll
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@tsundvoll tsundvoll merged commit 5d8f747 into equinor:main Dec 13, 2024
14 checks passed
@tsundvoll tsundvoll deleted the set-ids-from-isar-mission branch December 13, 2024 08:29
@tsundvoll tsundvoll mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand approved these changes

Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsundvoll @oysand