Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase time out for isar disconnect #1866

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Increase time out for isar disconnect #1866

merged 1 commit into from
Dec 19, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Dec 10, 2024 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol added the improvement Improvement to existing functionality label Dec 10, 2024
@Eddasol Eddasol self-assigned this Dec 10, 2024
@Eddasol Eddasol marked this pull request as ready for review December 10, 2024 15:15
@Eddasol Eddasol requested a review from oysand December 10, 2024 15:18
eivindsjovold
eivindsjovold previously requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run snyk checks

@Eddasol Eddasol force-pushed the timeOut branch 3 times, most recently from 32de7c3 to 968ad6b Compare December 16, 2024 07:42
andchiind
andchiind approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol force-pushed the timeOut branch 3 times, most recently from a01e779 to 78d44d5 Compare December 19, 2024 13:56
@Eddasol Eddasol dismissed eivindsjovold’s stale review December 19, 2024 14:37

Its outdated and already addressed

@Eddasol Eddasol merged commit cf8efad into equinor:main Dec 19, 2024
13 checks passed
@Eddasol Eddasol deleted the timeOut branch December 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

@oysand oysand Awaiting requested review from oysand

@eivindsjovold eivindsjovold Awaiting requested review from eivindsjovold

Assignees

@Eddasol Eddasol

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eddasol @andchiind @eivindsjovold