Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the everest load entry point #9358

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Remove the everest load entry point #9358

merged 1 commit into from
Nov 27, 2024

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Nov 27, 2024 •
edited
Loading

Issue
Resolves #8878

Approach
Delete the entry point, implementation file, and documentation

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj added release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI everest labels Nov 27, 2024
@verveerpj verveerpj self-assigned this Nov 27, 2024
DanSava
DanSava approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🧹

@verveerpj verveerpj merged commit dd7925c into main Nov 27, 2024
43 checks passed
@verveerpj verveerpj deleted the remove-load-entry-point branch November 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSava DanSava DanSava approved these changes

Assignees

@verveerpj verveerpj

Labels
everest release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete load entry point
2 participants
@verveerpj @DanSava