Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Everest config schema on the fly #9352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create Everest config schema on the fly #9352

wants to merge 1 commit into from
+7 −1,372

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 26, 2024 •
edited
Loading

Keeps the documentation automatically in sync.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 27, 2024
@oyvindeide oyvindeide changed the title Create schema on the fly Create Everest config schema on the fly Nov 27, 2024
DanSava
DanSava approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. With this change we will lose the ability to detect unwanted changes in the documentation added by changing the everest config class and subcomponents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSava DanSava DanSava approved these changes

Assignees
No one assigned
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
SCOUT
Status: Reviewed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyvindeide @DanSava