Fix manifest having too many files and not substituting #9233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
added
the
release-notes:bug-fix
eivindjahren
force-pushed
the
fix_manifest2
branch
2 times, most recently
from
456919e
to
39f78f6
Compare
oyvindeide
reviewed
Nov 19, 2024
Also makes substitution of <IENS> and <ITER> for all parameters and responses
eivindjahren
force-pushed
the
fix_manifest2
branch
from
39f78f6
to
24147bf
Compare
sondreso
approved these changes
Nov 22, 2024
| @@ -166,7 +167,9 @@ def write_to_runpath( | |||
| self, run_path: Path, real_nr: int, ensemble: Ensemble | |||
| ) -> None: | |||
| t = time.perf_counter() | |||
| file_out = run_path.joinpath(self.output_file) | |||
| file_out = run_path.joinpath( | |||
| substitute_runpath_name(str(self.output_file), real_nr, ensemble.iteration) | |||
There was a problem hiding this comment.
why str here and not other places? 🤔
There was a problem hiding this comment.
This is the only one of these that uses Path for self.output_file
|
This is marked as a bug fix, but no issue is marked in the description 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes substitution of and for
all parameters and responses
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable