Replace websockets with zmq #9173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
force-pushed
the
test_zmq
branch
3 times, most recently
from
feac786
to
5acae39
Compare
jonathan-eq
reviewed
Nov 20, 2024
| @@ -55,84 +51,83 @@ def __init__( | |||
| cert: Optional[Union[str, bytes]] = None, | |||
| max_retries: Optional[int] = None, | |||
| timeout_multiplier: Optional[int] = None, | |||
| dealer_name: str | None = None, | |||
There was a problem hiding this comment.
Too keep it the same style as the other parameters
Suggested change
| dealer_name: str | None = None, | |
| dealer_name: Optional[str] = None, |
There was a problem hiding this comment.
I wanted to be "modern", but will make it the same then :)
jonathan-eq
reviewed
Nov 20, 2024
Comment on lines
249
to
255
| else: | ||
| event = event_from_json(raw_msg) | ||
| if type(event) is EEUserCancel: | ||
| logger.debug("Client asked to cancel.") | ||
| self._signal_cancel() | ||
| elif type(event) is EEUserDone: | ||
| logger.debug("Client signalled done.") | ||
| self.stop() |
There was a problem hiding this comment.
Do we have to ACK messages from the monitor/client, or is it self acknowledging when it sees the EE stopping?
There was a problem hiding this comment.
I've decided not to do acknowledgements between the client and evaluator, since it is dispatchers that are problematic. But time will tell...
xjules
force-pushed
the
test_zmq
branch
5 times, most recently
from
e553dbc
to
016b43d
Compare
- dispatcher now send messages in chunks - dispatcher always for acknolwedgment from the evaluator - removing websockets, no more wait_for_evaluator - Settup encryption with curve - each dealer (client, dispatcher) will get a unique name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
POC: testing feasibility of zmq.
Refactor tests
Approach
Implementing router-dealer pattern with custom acknowledgments with zmq
Server / router (ensemble evaluator) gets messages and keeps track of connected clients wherein in additional it sends
ackmessage to dispachers to confirm that the message has been received .Dealer(s) = clients and dispatchers are sending messages to the router via:
which essentially batching multiple messages into one.
dispatcher now send messages in chunks
dispatcher always waits for acknowledgement from the evaluator
removing websockets, no more wait_for_evaluator
Setup encryption with curve
each dealer (client, dispatcher) will get a unique name
PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable