Fix _storage_main terminate_on_parent_death not working on mac
#9110
+68
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
from
adaf604
to
2d26299
Compare
jonathan-eq
added
the
release-notes:bug-fix
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
from
2d26299
to
91e15dc
Compare
jonathan-eq
changed the title
terminate_on_parent_death not working on mac
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
from
91e15dc
to
8bc64be
Compare
|
@JHolba Will outsourcing the parent-proccess-"living-situation"-polling to a new thread cause issues? This is the best thing chatgpt and I came up with. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9110 +/- ##
=======================================
Coverage 90.69% 90.70%
=======================================
Files 349 350 +1
Lines 21764 21787 +23
=======================================
+ Hits 19738 19761 +23
Misses 2026 2026
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
5 times, most recently
from
225d82e
to
bb80e7a
Compare
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
3 times, most recently
from
69c07b0
to
09fdd16
Compare
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
from
09fdd16
to
85b7774
Compare
JHolba
approved these changes
Nov 20, 2024
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
9 times, most recently
from
47d2bff
to
d5eceb6
Compare
Prior to this commit, the `terminate_on_parent_death` function was only usable on linux, due to it using the prctl command. This commit creates a new thread which polls the parent process, and signals terminate when it can no longer find the parent.
jonathan-eq
force-pushed
the
fix-storage-server-teardown
branch
from
d5eceb6
to
e7e30f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
terminate_on_parent_deathfunction was only usable on linux, due to it using the prctl command. This commit creates a new thread which polls the parent process, and signals terminate when it can no longer find the parent.Issue
Resolves #8452
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable