Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip gui test #6139

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Unskip gui test #6139

merged 1 commit into from
Sep 22, 2023

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 22, 2023

#5922

The test has run in 15 different actions, and haven't failed yet. Should be safe to reintroduce.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #6139 (3780c7b) into main (7d9af3d) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6139   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         350      350           
  Lines       21423    21423           
  Branches      839      839           
=======================================
  Hits        17667    17667           
- Misses       3458     3459    +1     
+ Partials      298      297    -1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eivindjahren eivindjahren marked this pull request as ready for review September 22, 2023 11:06
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust in you.

@eivindjahren eivindjahren merged commit 1f00934 into main Sep 22, 2023
40 checks passed
@eivindjahren eivindjahren deleted the unskip_gui_test branch September 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants