Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Migrate declarative_base SQLalchemy #241

Merged
merged 1 commit into from
May 2, 2023
Merged

Migrate declarative_base SQLalchemy #241

merged 1 commit into from
May 2, 2023

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented May 2, 2023 •
edited
Loading

Issue
Resolves #242

Approach
Short description of the approach

DanSava
DanSava approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

There are a lot of new mypy errors not sure if you want to fix those also to get this PR in or just ignore them for now .

@andreas-el
Copy link
Contributor Author

andreas-el commented May 2, 2023 •
edited
Loading

Looks good!

There are a lot of new mypy errors not sure if you want to fix those also to get this PR in or just ignore them for now .

I'm writing a new issue for that.
Feel is would be best to keep things separated.

#243

@andreas-el andreas-el merged commit 7eeba71 into equinor:main May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanSava DanSava DanSava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate SQLalchemy declarative_base
2 participants
@andreas-el @DanSava