1889 As editors we see a need to have text promotion cards to link to other pages

[millianapia]

No description provided.

[fernandolucchesi]

Left some comments

[fernandolucchesi]

Few comments:

1. title vs text content. Do we really need 2 fields? And it looks like only title is being used:

2. without space between components: space is there, what does it mean to be without? with space between components: space is applied to the cards, in which doesn't make sense to me specially on mobile view.

Is this the expected behaviour? (I haven't checked how the other component cited by Nick works)

3. Design issues: Text is too small. Inner paddings of cards are too small.
4. Feature is missing "11. Consider component to be hidden under access control"
5. Feature is missing "13. Should be possible to create with option not to have a link"
6. Not in the specification but I'd assume it has to be done: text should be always aligned left on mobile view

[millianapia]

• Feature is missing "11. Consider component to be hidden under access control"

this will be done later, not now. As discussed with @NickHaggerty1

[fernandolucchesi]

1. Text is not centered:
   

2. Text does not fit component properly:
   

3. Link is not showing up?
   
   

4. This description is a bit confusing: '
   Toggle button text
   This will add the text to link'. I did not understand what this does, and assume editors will also get confused.

5. Component name is Promo tiles array, I think Promo text tiles would be more descriptive for editors

[fernandolucchesi]

the component is still not looking as it should, label is not being displayed, arrow is on the center when text is to the left, and a lot of empty space between text and arrow:

Make sure to test all functionalities / screen resolutions and use cases when working on these kind of features. I recommend dragging the window to resize it instead of testing in fixed res, to ensure it looks good regardless of the screen resolution

[fernandolucchesi]

I haven't reviewed the css part yet since the component is not working as it should

[fernandolucchesi]

Doesn't work for big screens, grid is not limited at 2:

[fernandolucchesi]

I don't want to be super picky all the time, so I suggest checking with Nick if the way this is implemented is good enough. But if we are to follow the design suggested, there are a few discrepancies:

1. Spacing between components are too big IMO even when not using 'additional space':
   
   vs

2. Action (arrow) on mobile should be left aligned, not center aligned:
   

3. Line break doesn't work

4. I honestly don't see why we should limit this to 100 characters, or limit it at all. It is too few IMO, we can't even replicate the example card:
   

5. Spacing between text and action is a bit strange when comparing to the design
   

6. If it is a single card, text should be centered, it is aligned to left:

vs