Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report an error when unknown commands are given #486

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: report an error when unknown commands are given #486

wants to merge 5 commits into from

Commits on Aug 26, 2024

  1. fix: "device update --lock" should also unlock 

    Signed-off-by: Marques Johansson <[email protected]>
    @displague
    displague committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    34ccdcd View commit details
    Browse the repository at this point in the history

  2. chore(device update): use Cobra to enforce exclusive fields and no ad… 

    …dition args

Signed-off-by: Marques Johansson <[email protected]>
    @displague
    displague committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bef3873 View commit details
    Browse the repository at this point in the history

  3. docs: revise device update --locked arg 

    Signed-off-by: Marques Johansson <[email protected]>
    @displague
    displague committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    67dbcd0 View commit details
    Browse the repository at this point in the history

  4. chore: refactor device update locked to simple bool 

    Signed-off-by: Marques Johansson <[email protected]>
    @displague
    displague committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f304a91 View commit details
    Browse the repository at this point in the history

  5. fix: error when unknown arguments are included as action parameters 

    PR was made by manually walking the list of files in internal/ that did not specify Args and adding an Args definition.

git grep -n -e NewCommand -e Cmd\ :\=  $(git grep -L Args internal/)

"docs", "emdocs", and "completion" were not included because they use Args and have an existing Args definition.

Signed-off-by: Marques Johansson <[email protected]>
    @displague
    displague committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    08407f8 View commit details
    Browse the repository at this point in the history