-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle VRF Gateways in "metal gateway list" #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
displague
force-pushed
the
get_gateway_with_vrf
branch
from
August 7, 2024 17:38
e4f66b1
to
e1ecdd8
Compare
My default project ID was old (no longer exists). Updated to a valid one: go run ./cmd/metal/ gateways list -p $METAL_PROJECT_ID
+---------------+-------+-------+------------------+--------+-------------------------------+-----------------+
| ID | METRO | VXLAN | ADDRESSES | STATE | CREATED | TYPE |
+---------------+-------+-------+------------------+--------+-------------------------------+-----------------+
| redacted-uuid | am | 1002 | 192.168.100.2/22 | active | 2024-08-02 18:16:23 +0000 UTC | VrfMetalGateway |
+---------------+-------+-------+------------------+--------+-------------------------------+-----------------+ |
displague
commented
Aug 7, 2024
ctreatma
reviewed
Aug 7, 2024
displague
force-pushed
the
get_gateway_with_vrf
branch
from
August 8, 2024 18:46
e1ecdd8
to
411b8f2
Compare
Output with a VRF and non-VRF Gateway:
|
ctreatma
reviewed
Aug 8, 2024
gway := n.MetalGateway | ||
metalGways = append(metalGways, gway) | ||
for _, gwaysInner := range gways { | ||
gway := newGatewayish(gwaysInner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really count as getting rid of the if block within the for loop?
Signed-off-by: Marques Johansson <[email protected]>
ctreatma
force-pushed
the
get_gateway_with_vrf
branch
from
August 8, 2024 19:06
411b8f2
to
bdc01ab
Compare
ctreatma
approved these changes
Aug 8, 2024
This issue has been resolved in version 0.25.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
metal gateway list
support for VRF Gateways.Why is this needed?