Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Metal CLI support create shared interconnection with vlans and vrfs #397

Merged
merged 13 commits into from
Jan 23, 2024
Merged

feat: Metal CLI support create shared interconnection with vlans and vrfs #397

merged 13 commits into from
Jan 23, 2024

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala commented Nov 28, 2023 •
edited by displague
Loading

Part of #307

@displague
Copy link
Member

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@aayushrangwala aayushrangwala changed the title fix: Metal CLI support create shared interconnection with vlans and vrfs feat: Metal CLI support create shared interconnection with vlans and vrfs Dec 19, 2023
@aayushrangwala aayushrangwala marked this pull request as ready for review December 19, 2023 16:15
@aayushrangwala
Copy link
Contributor Author

Since this will need to be rebased. Perhaps after rebase we can add the 3 or so lines to pick up #388 (keep in mind, this changed with #331).

@displague Yes added the delete force changes in this PR

@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 19:31 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external January 18, 2024 21:44 — with GitHub Actions Abandoned
@aayushrangwala aayushrangwala requested a deployment to external January 19, 2024 19:56 — with GitHub Actions Abandoned
@aayushrangwala
feat: Add support for metal cli shared connections
16cba0b 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
refactor arg validation
33e8902 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
update random function generator
772efaf 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
fix: add default speed
7efe6c2 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
enhance: use force and confirmation while delete interconnections
82f0416
@aayushrangwala
fix: create interconnection cli flag descriptions
ad82f2a 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
docs update
062e38d 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
rollback adding '-' in test resources name as delimiter
c02e0cc
@aayushrangwala
update subcommand based on new api schema change
ad715c8 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Add tests for create shared interconnections
22b94ef 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Fetch current user and get default org to fetch conns for org
c81cfdf 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Use patch fix in equinix-sdk-go
289c5c6 
fix: virtual circuit clan set speed int64
@aayushrangwala
Add wait for connection to be deleted
c1f6eb4 
Signed-off-by: Ayush Rangwala <[email protected]>
@aayushrangwala
Copy link
Contributor Author

aayushrangwala commented Jan 23, 2024 •
edited
Loading 

coverage: 9.8% of statements in ./...
ok  	github.com/equinix/metal-cli/test/e2e/interconnections	4.865s	coverage: 9.8% of statements in ./...

Tests are passing for the changes in this PR, hence we can merge it

ctreatma
ctreatma approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only test failure I see in CI is a platform issue affecting a pre-existing device test that is not modified in this PR.

@ctreatma ctreatma merged commit 2bb181a into equinix:main Jan 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codinja1188 codinja1188 codinja1188 left review comments

@displague displague displague left review comments

@ctreatma ctreatma ctreatma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aayushrangwala @displague @ctreatma @codinja1188