Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - GUI: Implement external cmdline #351

Closed
wants to merge 1 commit into from
Closed

Conversation

equalsraf
Copy link
Owner

Nothing to see here yet, just working out the api.

  • I think this is api lvl 3, but I have not checked. the attachment code needs to be updated and we need to generate bindings.

ref #347

@gagbo
Copy link
Contributor

gagbo commented Dec 23, 2018

tl;dr : should we actually implement the cmdline as a sub-Shell widget ?

At first I thought that using a QTextEdit widget would be the best solution for the issue, because QTextEdit can show/edit Rich Text. Rich text support is important to do something with the formatting information, contrary to QLineEdit.

Another advantage of QTextEdit over QLineEdit is the ability to show multiple lines/paragraphs. QLineEdit is not able to properly answer cmdline_block_show and cmdline_block_append

But then I thought that if we're editing text in this window we probably want a sub Shell there don't we ? And the wildmenu should then be implemented as a special instance of PopupMenu ?

@jgehrig
Copy link
Collaborator

jgehrig commented Aug 6, 2020

Superseded by Pull #492 and Pull #586.

Marking as closed.

@jgehrig jgehrig closed this Aug 6, 2020
@jgehrig jgehrig deleted the tb-cmdline branch August 1, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants