Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check result of modbus_set_slave() #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r00t-
Copy link

@r00t- r00t- commented Oct 22, 2024

libmodbus considers some slave addresses invalid.
it will report an error, but mbpoll previously ignored this, leading to a crash with an assertion failure.

@r00t-
Copy link
Author

r00t- commented Oct 22, 2024

before this change:

[~/mbpoll]# ./mbpoll -m rtu -b 9600 -P none /dev/ttyUSB0 -a 248 -r 1 -c 1 -t 3 -u -v
[...]
Slave configuration...: address = 248, report slave id
Communication.........: /dev/ttyUSB0,       9600-8N1 
                        t/o 1.00 s, poll rate 1000 ms
mbpoll: modbus-rtu.c:94: _modbus_rtu_build_request_basis: Assertion `ctx->slave != -1' failed.
Aborted

after:

[~/mbpoll]# ./mbpoll -a 248 -b 9600 -t 3 -r 1 -c 2 /dev/ttyUSB0 
[...]
Slave configuration...: address = [248]
                        start reference = 1, count = 2
Communication.........: /dev/ttyUSB0,       9600-8E1 
                        t/o 1.00 s, poll rate 1000 ms
Data type.............: 16-bit register, input register table

./mbpoll: setting slave address failed: Invalid argument.

@r00t-
Copy link
Author

r00t- commented Oct 22, 2024

the same crash can be seen in #75

@r00t- r00t- force-pushed the check_set_slave_result branch from d755866 to 3ff31b0 Compare October 22, 2024 04:37
libmodbus considers some slave addresses invalid.
it will report an error, but mbpoll previously ignored this,
leading to a crash with an assertion failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant