-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove {i2extras} #86
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials-early/compare/md-outputs..md-outputs-PR-86 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-24 11:18:56 +0000 |
thanks! I'll start the review today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update! Brief edit suggestions and typos to incorporate. Some additional comments are below:
I think we can later use the simple-analysis.Rmd
file to still showcase the log-linear model more explicitly with all the assumptions and limitations before introducing EpiNow2. Assumptions and limitations and deciding why to choose a model are easier to interiorize than methods and possibly a more useful message. Filled as issue #87
Also, I would suggest that for the following PRs, try not to commit the renv.lock
file. First, check if the GH workflow check passes or not. We should prefer to update renv
files in isolated PRs only unless checks do not pass due to package versions. For this it seems not to break anything, so let's keep it.
## Peak estimation | ||
|
||
One can estimate the peak --the time with highest number of recorded cases-- using `estimate_peak()` function from the {incidence2} package. | ||
This function employs a bootstrapping method to determine the peak time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in further versions, we can add a callout explanation or simulation to understand the bootstrapping method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge 🚀
This PR completely removes the usage of {i2extras} from tutorials, and thus addressing issue #71. It also add section for calculating and visualizing the cumulative cases, and peak estimation.