Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full tutorial review day 01 early-task #19

Closed
wants to merge 426 commits into from
Closed

Full tutorial review day 01 early-task #19

wants to merge 426 commits into from

Conversation

avallecam
Copy link
Member

@avallecam avallecam commented Mar 25, 2024 •
edited
Loading

REMINDER: this is a Full review. Before merging, redirect this to main

This PR aims to collect in-line edit commit suggestions, as in this tutorial on "reviewing proposed changes in a PR"

online website content:

@avallecam
add introduction episode for lesson_build
61eab21
@avallecam
fix writing of objectives
8dfc626
@avallecam
add structure of questions to last two sections
72e2dd2
@avallecam
remove temporally setup logs chunk
4a52fc3
@avallecam
reduce object names and visible arguments
a49028c
@avallecam
change heading level
4e7ffd7
@avallecam
replace episode title
bcb2bc8
@avallecam
add template and questions for read data episode
e58131e
@avallecam
add draft chunk for discussion or challenge
4d4e487
@avallecam
add template and questions for describe data episode
e8e5121
@avallecam
add new episodes for build review
e393b3c
@avallecam
update heading titles
21b9fd9
@avallecam
add paragraphs to the what and how
1d937de
@avallecam
add keypoints from episode
5d0eae8
@avallecam
arrange text in what and how sections
d03c70c
@avallecam
clear template content
cc8e33b
@avallecam
rename figure
5c1b6f9
@avallecam
remove space within epinow function
19cfe2b
@avallecam
fix intro line to et1
a770ac2
@avallecam
rewrite intro sentence
7da8706
@avallecam
add prerequisites
eb5cd1b
@avallecam
replace prerequisite
b52eee9
@avallecam
add clear wording
1b4bdce
@avallecam
add text on why and epinow2 steps
90ee9b1
@avallecam
add definitions for delays
9354eaf
@avallecam
replace link with new R0 definition
fce9c84
@avallecam
specify the task as a point of reference
47509bb
@avallecam
edits after first review with grammarly
dfe1f40
@avallecam
relocate discussion after why section
bd769d2
@avallecam
rename episode for delays previous to read data
be4d6d9
avallecam added 19 commits March 28, 2024 12:24
@avallecam
clarify reference to model fit in figure
d014ebb
@avallecam
make NA visible
c3c352b
@avallecam
Merge branch 'full-review-upcoming' of https://github.com/epiverse-tr…
6167d4d 
…ace/tutorials-early into full-review-upcoming
@avallecam
relocate lognormal distribution step to get_params
0e3b1eb
@avallecam
clarify the aim of epiparameter
81ab900
@avallecam
rename episode
6b78eb2
@avallecam
relocate from time periods 2 distributions callout
3fa2519
@avallecam
fix NA expression in callout title
8291df4
@avallecam
rephrase challenge to an open exploration of delay
5fe9aea
@avallecam
relocate closure and specify challenges section
0439144
@avallecam
clean redundant outputs
96e45eb
@avallecam
rewrite episode wrapup and episodes connection
722f1af
@avallecam
remove reduntant output in intro and rewrite text
2dd3975
@avallecam
move warning after all analysis steps
b37eb39
@avallecam
move discussion to a stand-alone callout
263208c
@avallecam
add lognormal step and code completion tip
44f97af
@avallecam
move influenza challenge to functions episode
b03280b
@avallecam
move ebola challenge to end of episode
6749c76
@avallecam
add detail to challenges
c5d5c0e
@avallecam avallecam mentioned this pull request Mar 28, 2024
Closed
@avallecam avallecam added the upcoming-training To prioritize label Mar 28, 2024
@avallecam avallecam mentioned this pull request Apr 2, 2024
Merged
CarmenTamayo
CarmenTamayo reviewed Apr 2, 2024
View reviewed changes
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Outdated Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
episodes/delays-reuse.Rmd Outdated Show resolved Hide resolved
episodes/delays-reuse.Rmd Outdated Show resolved Hide resolved
episodes/delays-reuse.Rmd Show resolved Hide resolved
@avallecam avallecam mentioned this pull request Apr 8, 2024
Merged
avallecam added a commit that referenced this pull request Apr 8, 2024
@avallecam
add edits from PR #19
b3a8bdc
avallecam added a commit that referenced this pull request Apr 8, 2024
@avallecam
add edits from PR #19
be3e369
@avallecam
Copy link
Member Author

Closing this PR as its edit suggestions were redirected to main in #43 and #50

@avallecam avallecam closed this Apr 8, 2024
@avallecam avallecam deleted the full-review-upcoming branch May 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenTamayo CarmenTamayo CarmenTamayo left review comments

@adamkucharski adamkucharski adamkucharski left review comments

Assignees
No one assigned
Labels
upcoming-training To prioritize
Projects
No open projects
upcoming-training April 11/18/25
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avallecam @adamkucharski @CarmenTamayo @Bisaloo @Degoot-AM