Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing caption numbering and positioning on Rmd report #157

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jpavlich
Copy link
Member

@jpavlich jpavlich commented May 8, 2024

Fixes #156
Fixes #158
Fixes #166
Issue #159 may be fixed, although further testing is required

…`, to move figure captions above each image
@jpavlich jpavlich linked an issue May 8, 2024 that may be closed by this pull request
@jpavlich jpavlich requested a review from GeraldineGomez May 8, 2024 18:34
@jpavlich jpavlich marked this pull request as draft May 8, 2024 18:36
@jpavlich jpavlich changed the title Added latex package floatrow to the skeleton.Rmd header-includes Fixing caption numbering and positioning on Rmd report May 8, 2024
@jpavlich
Copy link
Member Author

jpavlich commented May 8, 2024

The connection errors that may appear on the checks should be fixed with PR #152

@jpavlich
Copy link
Member Author

jpavlich commented May 8, 2024

@GeraldineGomez these fixes work for me on Linux. I guess you should test it in Windows to ensure the reports are generated correctly

@jpavlich jpavlich marked this pull request as ready for review May 8, 2024 22:40
@jpavlich jpavlich marked this pull request as draft May 10, 2024 14:28
@jpavlich jpavlich marked this pull request as ready for review May 10, 2024 15:02
Copy link
Member

@GeraldineGomez GeraldineGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpavlich, thank you very much for collaborating on those changes and issues 🚀🙏😊.

Regarding Issue 159: The addition of bookdown works well on Windows.

I conducted some tests. When I generated the report in HTML format, the cover image was missing and displays the following text:

image

and the references in the HTML file appear like this:
image

The PDF file's cover displays the following text:

image

This might be due to the addition in the YAML of:

image

I believe this could be a good solution to address the warning related to the title when generating HTML. It's probable that some updates are necessary in the skeleton configuration.

@jpavlich
Copy link
Member Author

@GeraldineGomez Maybe the reason for the above behavior is that you selected the Knit to HTML option? If so, please try Knit to html_document2. That one seem to work fine for me in my windows VM.

image

I guess I will have to thoroughly document that before release

@jpavlich jpavlich requested a review from GeraldineGomez May 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants