Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modify_defaults() (fixes #16) #27

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Remove modify_defaults() (fixes #16) #27

merged 8 commits into from
Aug 21, 2024

Conversation

chartgerink
Copy link
Member

This PR removes modify_defaults() in favor of using utils::modifyList() directly instead.

I also added a clarification of why keep.null is needed, to provide more clarity throughout the comments.

@chartgerink chartgerink linked an issue Aug 14, 2024 that may be closed by this pull request
@chartgerink chartgerink merged commit 926df3a into main Aug 21, 2024
9 checks passed
@chartgerink chartgerink deleted the fix/16 branch August 21, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate the necessity of the custom modify_defaults() function
1 participant