Remove **linelist** deprecated items #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisaloo
reviewed
Jul 25, 2024
Bisaloo
reviewed
Jul 25, 2024
chartgerink
force-pushed
the
chjh/remove-deprecated
branch
from
bfde209 to
35e661f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes arguments and functions that linelist already deprecated. This way there is no deprecated code in this new package, and the deprecations can be handled by linelist where relevant.
Requesting a review to ensure there is space to discuss this prior to merging. I'd rather check in once too often 😊