Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated release blog post vaccineff - v1.0.0 #346

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 2, 2024

Automated changes by create-pull-request GitHub action

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for tourmaline-marshmallow-241b40 failed.

Name Link
🔨 Latest commit 17d28f7
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/67506a5a2a264f0008c5ac0e

@Bisaloo
Copy link
Member

Bisaloo commented Dec 3, 2024

@davidsantiagoquevedo, could you review this release blog post for correctness and completeness please?

For a first CRAN release, I would encourage you to consider a manual blog post if you have the bandwidth to do it soon.

@davidsantiagoquevedo
Copy link
Member

Hi @Bisaloo I added some details to the description. However, some checks are not passing and I couldn't solve them. Could you please check it?

@Bisaloo
Copy link
Member

Bisaloo commented Dec 4, 2024

Yes, the checks fail because the blog post contains R code to be rendered, which the netlify preview cannot do. You don't have to worry about it.

The blog post looks good. Would it make sense to add here some of the examples present in the package README so readers can have a feel of what the package can do for them, even before clicking on the link?

@davidsantiagoquevedo
Copy link
Member

Yes, the checks fail because the blog post contains R code to be rendered, which the netlify preview cannot do. You don't have to worry about it.

The blog post looks good. Would it make sense to add here some of the examples present in the package README so readers can have a feel of what the package can do for them, even before clicking on the link?

Good idea! I added an example and a small explanation. Is it necessary to call library(vaccineff)? Or is this redundant?

Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

Is it necessary to call library(vaccineff)? Or is this redundant?

Yes, it's good to have library(vaccineff) so it can be copied/pasted and run directly.

posts/vaccineff_v1.0.0/index.qmd Outdated Show resolved Hide resolved
Co-authored-by: Hugo Gruson <[email protected]>
@Bisaloo Bisaloo merged commit f6c5222 into main Dec 4, 2024
5 of 9 checks passed
@Bisaloo Bisaloo deleted the automated-release-post-1733182715 branch December 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants