Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progressive enhancement in OOP post #296

Merged
merged 14 commits into from
Jul 5, 2024
Merged

Add progressive enhancement in OOP post #296

merged 14 commits into from
Jul 5, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jul 4, 2024

  • The post specifies a license if you don't want to use the default CC BY
  • All authors have an ORCID iD
  • Relevant keywords / tags has been added. In particular, if you want your post to be shared on R-bloggers, you must tag it with R
  • Images or other external resources have been committed and pushed
  • The post uses pure quarto syntax, rather than HTML or R code, unless necessary

Right before merging:

  • The date field has been updated
  • All reviewers have been acknowledged in a short paragraph
  • A PR has been opened in the blueprints to link to this post
  • The post has been re-rendered and content of the _freeze/ folder is up-to-date

@Bisaloo Bisaloo requested a review from chartgerink as a code owner July 4, 2024 08:34
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
🔨 Latest commit 2778702
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/6687fb72b9b7570008d3fd9b
😎 Deploy Preview https://deploy-preview-296--tourmaline-marshmallow-241b40.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the post, Hugo. I think it would have been nice to have more concrete examples but if that is not intended, this is still fine as nuggets of wisdom.

@Bisaloo Bisaloo force-pushed the graceful-degradation branch from 60287b0 to c222a94 Compare July 5, 2024 10:49
@@ -0,0 +1,152 @@
---
title: "Improving Ecosystem Interoperability Iteratively via Progressive Enhancement"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just realising we are inconsistent with the use of capitalisation and sentence case for our titles. We should probably harmonise this in a separate issue/PR.


Object oriented programming and S3 classes offer a convenient way to iteratively add interoperability in the ecosystem in a way that is minimally disruptive to users and developers.
Newly classed input support can be added via custom methods (after converting the existing function to a generic if necessary).
Newly classed output support can be added via progressive enhancement, by ensuring that the new class is a subclass of the old one, that downstream code uses good practices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement "that downstream code uses good practice" doesn't follow smoothly after the command but I'm unsure of what you're trying to say.

Copy link
Member

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hugo. The added examples will enhance your points.

@Bisaloo Bisaloo merged commit 0833068 into main Jul 5, 2024
12 checks passed
@Bisaloo Bisaloo deleted the graceful-degradation branch July 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants