Adding options for ioc main #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures on OSX are unrelated (#25) to this PR. |
|
Are you able to squash these commits into only a couple please? |
ZohebShaikh
force-pushed
the
adding-options-for-ioc-main
branch
from
5962b38 to
e1284a4
Compare
I've gone ahead and squashed the commits into a single one as requested. Please feel free to let me know if there's anything else you'd like me to adjust! |
|
CI is broken due to |
|
@ZohebShaikh can you rebase this on main so we can try the CI again? |
ZohebShaikh
force-pushed
the
adding-options-for-ioc-main
branch
from
e1284a4 to
8ac8589
Compare
ZohebShaikh
force-pushed
the
adding-options-for-ioc-main
branch
from
8ac8589 to
7f86378
Compare
|
@OCopping I noticed the CI is passing. Could we proceed with the merge? |
coretl
approved these changes
Dec 19, 2024
OCopping
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created in relation to this issue epics-base/pvxs#49