Move the root options to a Pydantic Model #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long term is goal is to move all CLI configurations to models. Currently attributes are slapped onto one big inherited object and make it difficult to determine where something is coming from, and there is significant coupling. Moving the options into a base model allows for all validation and conditional logic to be handled within the model, and then the model can be passed to places where the configuration may be needed. This will lessen the overuse of passing around big sets of kwargs and taking out what is needed, and will ensure that the CLI options are seamlessly available in all the different areas they are needed. This starts with just the RootCommand, which takes the "global" or top level options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long term is goal is to move all CLI configurations to models. Currently attributes are slapped onto one big inherited object and make it difficult to determine where something is coming from, and there is significant coupling.
Moving the options into a base model allows for all validation and conditional logic to be handled within the model, and then the model can be passed to places where the configuration may be needed. This will lessen the overuse of passing around big sets of kwargs and taking out what is needed, and will ensure that the CLI options are seamlessly available in all the different areas they are needed.
This starts with just the RootCommand, which takes the "global" or top level options.