Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version compatibility and other fixes #95

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

rmaynardap
Copy link
Contributor

After merging from upstream we identified several issues with the changes over the last week:

  1. The .tfvars file needs to be named .auto.tfvars to be properly picked up
  2. The pyproject.toml still indicated python 3.10 was compatible, it is not, bumped to 3.11
  3. Some of the f-strings use double quotes inside, which works in 3.12 but not 3.11, fixed them to be usable in 3.11
  4. Using -lockfile=readonly really cleans up the output, but currently isn't reliable enough; submodules need to be pulled and checked too prior to terraform init, this can probably be done with the terraform get command
  5. When checking for versions, symlinks were not being followed and they should be since TF will follow them, the behavior needs to be the same
  6. A partial mirror, where "includes" was specified did not work because a list of providers was being passed instead of a list of strings matching the provider tag, this is fixed

rmaynardap and others added 5 commits June 17, 2024 10:14
Merge Upstream into fork
python version changes / os.walk fix
In order to be loaded without a -var parameter, the file needs to end
with .auto.tfvars. This was changed when moving the value to a constant,
in order to try and be more consistent and predictable.
@ephur ephur merged commit 76e5af7 into ephur:master Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants