Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm/null/follow symlinks #94

Closed
wants to merge 2 commits into from

Conversation

rmaynardap
Copy link
Contributor

As I initially suspected it was an issue to not follow symlinks, but there are a few other things addressed now, and a couple to address later:

  1. The versions.tf constraint only checks the "root" module for required providers, the root module -should- include all of the modules required by submodules it calls, but we haven't done this and fixing will be a lot of updates. A longer term resolution will be to use "terraform get" to pull all of the sub-modules used, and inspect them as well for requirements. To unblock the implementation of our crowdstrike module however, I temporarily removed the -lockfile=readonly from the terraform init command which corrects the issue, and doesn't change behavior significant, but it will continue to generate the cumbersome output we already see from "init"

  2. Follow symlinks when doing the os.walk to capture files that are symlinked to others

  3. This actually now requires python 3.11, updated that in the requirements, but in the future should implement Tox or something similar to test against different python versions

  4. Some tests would not run with python 3.11, but were easily corrected by not using "'s inside of an f-string

  5. "Partial" mirroring was not working right, and there isn't a test case for this. I implemented the fix now, but for later will add an appropriate test case to cover "partial" mirrors (partial mirror is when 3 of 5 plugins are mirrored, only fetching the missing 2)

@rmaynardap rmaynardap closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant