Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I initially suspected it was an issue to not follow symlinks, but there are a few other things addressed now, and a couple to address later:
The versions.tf constraint only checks the "root" module for required providers, the root module -should- include all of the modules required by submodules it calls, but we haven't done this and fixing will be a lot of updates. A longer term resolution will be to use "terraform get" to pull all of the sub-modules used, and inspect them as well for requirements. To unblock the implementation of our crowdstrike module however, I temporarily removed the -lockfile=readonly from the terraform init command which corrects the issue, and doesn't change behavior significant, but it will continue to generate the cumbersome output we already see from "init"
Follow symlinks when doing the os.walk to capture files that are symlinked to others
This actually now requires python 3.11, updated that in the requirements, but in the future should implement Tox or something similar to test against different python versions
Some tests would not run with python 3.11, but were easily corrected by not using "'s inside of an f-string
"Partial" mirroring was not working right, and there isn't a test case for this. I implemented the fix now, but for later will add an appropriate test case to cover "partial" mirrors (partial mirror is when 3 of 5 plugins are mirrored, only fetching the missing 2)