Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noe/android prebuild #1356

Merged
merged 18 commits into from
Dec 19, 2024
Merged

Noe/android prebuild #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9a0d26c
Config for android prebuild
nmalzieu Dec 12, 2024
c21411f
Remove android folder and configure plugins and config for prebuild
nmalzieu Dec 13, 2024
1901fab
Increase memory for EAS
nmalzieu Dec 17, 2024
1267825
No need for android build script
nmalzieu Dec 17, 2024
7fffe25
Move google services
nmalzieu Dec 17, 2024
c315782
Google services
nmalzieu Dec 17, 2024
2096fbe
production google services
nmalzieu Dec 19, 2024
c9d5093
Upgrade XMTP SDK and fix Android notifications for DM
nmalzieu Dec 19, 2024
57fd7c3
fix builds
alexrisch Dec 19, 2024
dbcf419
fix build
alexrisch Dec 19, 2024
a0e06bc
fix pod file
alexrisch Dec 19, 2024
78463ce
fix for profiles
alexrisch Dec 19, 2024
d36fde2
Fix TSC
alexrisch Dec 19, 2024
54d4027
Correct syntax for Android
alexrisch Dec 19, 2024
fc38ff6
fix iOS Build from upgrade
alexrisch Dec 19, 2024
c3b4443
fix pattern
alexrisch Dec 19, 2024
6457c78
iOS Build last update
alexrisch Dec 19, 2024
7d6ca2f
Merge branch 'release/3.0.0' into noe/android-prebuild
alexrisch Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build-app-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Install dependencies
run: yarn install
Expand All @@ -46,6 +46,7 @@ jobs:
echo "EXPO_PUBLIC_EXPO_PROJECT_ID=${{ secrets.EXPO_PUBLIC_EXPO_PROJECT_ID }}" >> .env.production
echo "EXPO_PUBLIC_PRIVY_APP_ID=${{ secrets.EXPO_PUBLIC_PRIVY_APP_ID }}" >> .env.production
echo "EXPO_PUBLIC_EVM_RPC_ENDPOINT=${{ secrets.EXPO_PUBLIC_EVM_RPC_ENDPOINT }}" >> .env.production
echo "SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}" >> .env.production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Ensure secure handling of SENTRY_AUTH_TOKEN in build workflow

Including SENTRY_AUTH_TOKEN in .env.production can pose a security risk if the file is exposed. Confirm that .env.production is not checked into version control and that logs do not expose secret values.

Also applies to: 92-92


- name: Update EAS config with env variables
run: node scripts/Øbuild/eas.js --env production
Expand All @@ -67,7 +68,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Install dependencies
run: yarn install
Expand All @@ -88,6 +89,7 @@ jobs:
echo "EXPO_PUBLIC_EXPO_PROJECT_ID=${{ secrets.EXPO_PUBLIC_EXPO_PROJECT_ID }}" >> .env.production
echo "EXPO_PUBLIC_PRIVY_APP_ID=${{ secrets.EXPO_PUBLIC_PRIVY_APP_ID }}" >> .env.production
echo "EXPO_PUBLIC_EVM_RPC_ENDPOINT=${{ secrets.EXPO_PUBLIC_EVM_RPC_ENDPOINT }}" >> .env.production
echo "SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}" >> .env.production

- name: Update EAS config with env variables
run: node scripts/build/eas.js --env production
Expand All @@ -109,7 +111,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Increment version number
run: |
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/build-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Install dependencies
run: yarn install
Expand All @@ -54,6 +54,7 @@ jobs:
echo "EXPO_PUBLIC_EXPO_PROJECT_ID=${{ secrets.EXPO_PUBLIC_EXPO_PROJECT_ID }}" >> $env_file
echo "EXPO_PUBLIC_PRIVY_APP_ID=${{ secrets.EXPO_PUBLIC_PRIVY_APP_ID }}" >> $env_file
echo "EXPO_PUBLIC_EVM_RPC_ENDPOINT=${{ secrets.EXPO_PUBLIC_EVM_RPC_ENDPOINT }}" >> $env_file
echo "SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}" >> $env_file

- name: Update EAS config with env variables
run: |
Expand All @@ -63,9 +64,6 @@ jobs:
node scripts/build/eas.js --env preview
fi

- name: Update Android Files
run: node scripts/build/android/build.js

- name: Build for Android
run: |
if [ "${{ github.event.inputs.environment || 'Production' }}" == "Production" ]; then
Expand All @@ -85,7 +83,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Install dependencies
run: yarn install
Expand All @@ -111,6 +109,7 @@ jobs:
echo "EXPO_PUBLIC_EXPO_PROJECT_ID=${{ secrets.EXPO_PUBLIC_EXPO_PROJECT_ID }}" >> $env_file
echo "EXPO_PUBLIC_PRIVY_APP_ID=${{ secrets.EXPO_PUBLIC_PRIVY_APP_ID }}" >> $env_file
echo "EXPO_PUBLIC_EVM_RPC_ENDPOINT=${{ secrets.EXPO_PUBLIC_EVM_RPC_ENDPOINT }}" >> $env_file
echo "SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}" >> $env_file

- name: Update EAS config with env variables
run: |
Expand Down Expand Up @@ -147,7 +146,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Increment version numbers
run: node scripts/build/incrementBuildNumbers.js
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-android-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup node
uses: actions/[email protected]
with:
node-version: 18.x
node-version: 20.x
cache: "yarn"

- name: Set up JDK 17
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-ios-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup node
uses: actions/[email protected]
with:
node-version: 18.x
node-version: 20.x
cache: "yarn"

- name: 🏗 Setup EAS
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-new-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: "18"
node-version: "20"

- name: Setup Git
run: |
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ ios/Converse.xcworkspace/xcshareddata/swiftpm/Package.resolved

# Reassure output directory
.reassure

# Android
/android/
16 changes: 0 additions & 16 deletions android/.gitignore
View file
Open in desktop

This file was deleted.

Loading
Loading