Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add people (Unit API) #108

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Add people (Unit API) #108

merged 6 commits into from
Nov 7, 2023

Conversation

williambelle
Copy link
Member

No description provided.

@williambelle williambelle requested a review from obieler October 19, 2023 16:37
obieler
obieler reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@obieler obieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme relevé oralement, si l'unité n'a pas de personnes accrédités (à afficher), exemple 'DATAGOV', l'API actuelle ne retourne pas la clé 'people'. Du coup, on a ici dans le front '0 personnes' affichées :(

@williambelle williambelle reopened this Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/services/people.service.js 100.00% <100.00%> (ø)
src/services/unit.service.js 100.00% <100.00%> (ø)
src/utils/ldap.util.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@williambelle williambelle requested a review from obieler October 30, 2023 13:19
obieler
obieler reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@obieler obieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@williambelle williambelle merged commit 73f6745 into main Nov 7, 2023
4 checks passed
@williambelle williambelle deleted the feature/people-unit branch November 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obieler obieler obieler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williambelle @codecov-commenter @obieler