Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for IE, Blackberry and Baidu #730

Merged
merged 3 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions assets/components/atoms/definition-list/definition-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,3 @@
grid-column: 1 / span 2;
}
}

@include ie11('.definition-list-grid') {
display: block;
}

@include ie11('.definition-list-grid dt') {
float: left;
margin: 0;
border: none;
}

@include ie11('.definition-list-grid dd') {
@include clearfix;
}

@include ie11('.definition-list-grid .definition-list-item-full') {
float: none;
width: 100%;

@include clearfix;
}

50 changes: 0 additions & 50 deletions assets/components/content-types/study-plan/study-plan-ie.scss

This file was deleted.

2 changes: 0 additions & 2 deletions assets/components/content-types/study-plan/study-plan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@ notes: |

Please override the columns width (if they do not fit your needs) by using a CSS variable: `<div class="study-plan table-like" style="--table-columns: 1fr minmax(200px, 3fr) minmax(auto, 1fr) minmax(200px, 3fr) 3fr 1fr">`.

The default behaviour is kept on IE, the content stays readable (the table might be a bit wonky when some columns are missing though).

On mobile, the tables are scrollable horizontally.
9 changes: 0 additions & 9 deletions assets/components/entrypoint.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* globals jQuery, Tablesaw */

import objectFitImages from 'object-fit-images';
import upload from './atoms/upload/upload';
import breadcrumb from './molecules/breadcrumb/breadcrumb';
import datepicker from './molecules/datepicker/datepicker';
Expand Down Expand Up @@ -53,14 +52,6 @@ jQuery.fn.extend({

guide();
anchors();

// Init polyfill for Object Fit on IE11
const isIE11 = !!window.MSInputMethodContext && !!document.documentMode;
if (isIE11) {
objectFitImages();
jQuery('body').addClass('ie');
}

}
});

Expand Down
1 change: 0 additions & 1 deletion assets/components/entrypoint.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
@import 'content-types/publication/publication';
@import 'content-types/science-question/science-question';
@import 'content-types/study-plan/study-plan';
@import 'content-types/study-plan/study-plan-ie';
@import 'content-types/press-review/press-review';
@import 'content-types/section/section';
@import 'content-types/school/school';
Expand Down
7 changes: 0 additions & 7 deletions assets/components/molecules/card/card.scss
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,6 @@ a.card {
}
}

// Fix for IE not handling image height correctly
// https://github.com/philipwalton/flexbugs/issues/75
.card-img-top,
.card-overlay .card-img {
min-height: 1px;
}

// Grayscale look, see event finished
.card-grayscale {
&:hover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,3 @@
}
}
}

@include ie11('.key-number-group .key-number') { flex: 0 0 20%; }
@include ie11('.key-number-group .key-large') { flex: 0 0 45%; }
26 changes: 0 additions & 26 deletions assets/config/layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,29 +75,3 @@
@extend .mt-n#{$i};
}
}

@include ie11('.container-grid') {
display: block;
}

@include ie11('.container-grid > *') {
max-width: col-width(lg, 10);
margin: 0 auto;
}

@include media-breakpoint-up(lg) {
@include ie11('.container-grid > *') {
max-width: col-width(lg, 8);
}
}

@include media-breakpoint-up(xl) {
@include ie11('.container-grid > *') {
max-width: col-width(xl, 6);
}
}

@include ie11('.container-grid .container-full') {
max-width: 100%;
width: 100%;
}
10 changes: 0 additions & 10 deletions assets/config/mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,3 @@
border-right: $trapeze-height solid transparent;
transition: border $trapeze-animation-duration;
}


// IE 11 mixin
// WARNING: Autoprefixer is off inside this.
@mixin ie11($selector) {
:-ms-fullscreen, :root #{$selector} {
/* autoprefixer: off */
@content;
}
}
15 changes: 7 additions & 8 deletions docs/contribute/support-and-request.html
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,13 @@ <h1 class="mt-5">FAQ</h1>
<p>
Elements is supporting the following browsers and versions:
<ul>
<li>Chrome 63, 64+</li>
<li>Chrome for Android 64+</li>
<li>Firefox 57, 58+</li>
<li>Safari 10.1, 11+</li>
<li>Safari iOS 10.3, 11+</li>
<li>Internet Explorer 11</li>
<li>Edge 15, 16+</li>
<li>Opera 49, 50+</li>
<li>Chrome 123, 124+</li>
<li>Chrome for Android 123, 124+</li>
<li>Firefox 125, 126+</li>
<li>Safari 17.4, 17.5+</li>
<li>Safari iOS 16.6, 16.7+</li>
<li>Edge 124, 125+</li>
<li>Opera 109, 110+</li>
</ul>
</p>
</div>
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"main": "dist/js/elements.min.js",
"browserslist": [
"> 1% in CH",
"last 2 versions"
"last 2 versions",
"not dead"
],
"eslintConfig": {
"parser": "@babel/eslint-parser",
Expand Down Expand Up @@ -168,7 +169,6 @@
"jquery": "^3.7.1",
"jquery-mousewheel": "^3.1.13",
"multiple-select": "^1.5.2",
"object-fit-images": "^3.2.4",
"pickadate": "^3.6.4",
"popper.js": "^1.16.1",
"tablesaw": "^3.1.2"
Expand Down
5 changes: 0 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7136,11 +7136,6 @@ object-assign@^4, object-assign@^4.1.1:
resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
integrity sha1-IQmtx5ZYh8/AXLvUQsrIv7s2CGM=

object-fit-images@^3.2.4:
version "3.2.4"
resolved "https://registry.yarnpkg.com/object-fit-images/-/object-fit-images-3.2.4.tgz#6c299d38fdf207746e5d2d46c2877f6f25d15b52"
integrity sha512-G+7LzpYfTfqUyrZlfrou/PLLLAPNC52FTy5y1CBywX+1/FkxIloOyQXBmZ3Zxa2AWO+lMF0JTuvqbr7G5e5CWg==

[email protected]:
version "3.0.0"
resolved "https://registry.yarnpkg.com/object-hash/-/object-hash-3.0.0.tgz#73f97f753e7baffc0e2cc9d6e079079744ac82e9"
Expand Down
Loading