Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean JS for Search #698

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Clean JS for Search #698

merged 1 commit into from
Feb 23, 2024

Conversation

williambelle
Copy link
Member

  • Fix eslint warnings and errors
  • Fix deprecated jQuery API

- Fix eslint warnings and errors
- Fix deprecated jQuery API
@williambelle
Copy link
Member Author

./node_modules/.bin/eslint assets/components/molecules/search

   5:36  error    Unexpected function expression                                                                 prefer-arrow-callback
   5:36  warning  Unexpected unnamed function                                                                    func-names
   5:45  error    'event' is defined but never used                                                              no-unused-vars
   5:51  error    Missing space before opening brace                                                             space-before-blocks
   7:5   error    Unexpected var, use let or const instead                                                       no-var
   8:5   error    Unexpected var, use let or const instead                                                       no-var
  13:9   error    There should be no space after this paren                                                      space-in-parens
  13:42  error    There should be no space before this paren                                                     space-in-parens
  19:35  error    Unexpected function expression                                                                 prefer-arrow-callback
  19:35  warning  Unexpected unnamed function                                                                    func-names
  19:44  error    'event' is defined but never used                                                              no-unused-vars
  19:50  error    Missing space before opening brace                                                             space-before-blocks
  21:5   error    Unexpected var, use let or const instead                                                       no-var
  22:5   error    Unexpected var, use let or const instead                                                       no-var
  22:9   error    'searchField' is assigned a value but never used. Allowed unused vars must match /[uU]nused/u  no-unused-vars

✖ 15 problems (13 errors, 2 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

Copy link

github-actions bot commented Dec 1, 2023

Unit Test Results

267 tests   267 ✔️  0s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 5cec732.

Copy link

github-actions bot commented Dec 1, 2023

🔎 Download the Backstop report for this pull request (link valid for 90 days):

@williambelle williambelle merged commit 84213b0 into dev Feb 23, 2024
4 checks passed
@williambelle williambelle deleted the chore/clean-search-js branch February 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant