Hamburger button (#674)

* Use button tag instead of div
epfl-si · Aug 7, 2023 · c769c3a · c769c3a
1 parent a9aeb44
commit c769c3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/assets/components/atoms/nav-lang/nav-lang.twig b/assets/components/atoms/nav-lang/nav-lang.twig
@@ -1,8 +1,8 @@
 <nav class="nav-lang ml-auto dropdown" aria-label="Change language">
-  <a href="#" class="dropdown-toggle btn btn-secondary" aria-haspopup="true" aria-expanded="false" data-toggle="dropdown">
+  <button class="dropdown-toggle btn btn-secondary" aria-haspopup="true" aria-expanded="false" data-toggle="dropdown">
     {% include '@atoms/icon/icon.twig' with {icon: 'icon-planet'} %}
     <span>FR</span>
-  </a>
+  </button>
   <ul class="dropdown-menu">
     <li>
       <a aria-label="Français (Current language)" class="active dropdown-item" >

diff --git a/assets/components/atoms/nav-toggle-mobile/nav-toggle-mobile.twig b/assets/components/atoms/nav-toggle-mobile/nav-toggle-mobile.twig
@@ -1,8 +1,8 @@
-<div class="btn btn-secondary nav-toggle-mobile d-xl-none">
+<button class="btn btn-secondary nav-toggle-mobile d-xl-none">
   <span class="label">Menu</span>
   <div class="hamburger">
     <span></span>
     <span></span>
     <span></span>
   </div>
-</div>
+</button>