Skip to content

Commit

Permalink
Better CSS and linter compliant
Browse files Browse the repository at this point in the history
  • Loading branch information
ponsfrilus committed Mar 17, 2017
1 parent ffd81dd commit b7b9dd0
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 10 deletions.
10 changes: 10 additions & 0 deletions build/webpack.base.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ module.exports = {
},
module: {
rules: [
{ // eslint
enforce: 'pre',
test: /\.(vue|js)$/,
loader: 'eslint-loader',
include: projectRoot,
exclude: /node_modules/,
options: {
formatter: require('eslint-friendly-formatter')
}
},
{
test: /\.js$/,
loader: 'babel-loader',
Expand Down
3 changes: 0 additions & 3 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@
* Root component
*/
export default {}
var foo = "bar" + 'baz';
</script>

<style>
Expand Down
7 changes: 4 additions & 3 deletions src/components/EPFLTopics.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<script>
import EPFLTopic from './partials/EPFLTopic'
export default {
components: {"epfl-topic": EPFLTopic},
components: {'epfl-topic': EPFLTopic},
data () {
return {
topics: []
Expand All @@ -21,9 +21,10 @@ export default {
this.$http.get('https://api.github.com/search/repositories?q=topic:epfl')
.then((response) => {
this.topics = response.data.items.sort((a, b) => {
if (a.stargazers_count == 0 && b.stargazers_count == 0) {
if (a.stargazers_count === 0 && b.stargazers_count === 0) {
return b.stargazers_count - a.stargazers_count
} else {
}
else {
return b.forks_count - b.forks_count
}
})
Expand Down
4 changes: 2 additions & 2 deletions src/components/partials/Avatar.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template lang="html">
<div class="avatar">
<span class="avatar">
<a :href="dude.html_url"><img class="avatarimg" :src="dude.avatar_url" alt="" :width="size + 'px'" :title="dude.login" /><span v-if="login"> @{{ dude.login }}</span></a>
</div>
</span>
</template>

<script>
Expand Down
5 changes: 3 additions & 2 deletions src/components/partials/EPFLTopic.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ export default {
</script>
<style>
div.topic {
border: 1px solid lightgreen;
border-left: 1px solid lightgreen;
border-radius: 4px;
margin: 20px;
padding: 5px;
margin: 15px;
line-height: 2em;
}
</style>

0 comments on commit b7b9dd0

Please sign in to comment.