Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2312 - Export of ambiguous monomers doesn't work (error appears) to any export format (even to SVG/PNG) except KET #2528

Merged
merged 2 commits into from
Oct 8, 2024
Merged

#2312 - Export of ambiguous monomers doesn't work (error appears) to any export format (even to SVG/PNG) except KET #2528

merged 2 commits into from
Oct 8, 2024

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Add UT.

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach
#2312 - Export of ambiguous monomers doesn't work (error appears) to…
81a8015 
… any export format (even to SVG/PNG) except KET

Fix code. Add UT.
This was linked to issues Oct 8, 2024
Export of ambiguous monomers doesn't work (error appears) to any export format (even to SVG/PNG) except KET #2312
Closed
Export of variant monomers to MOL V3000 causes an error (always) #2306
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit a73614f into release/1.25 Oct 8, 2024
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2312-export-ambiguous-to-mol branch October 8, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AliaksandrDziarkach @AlexanderSavelyev