Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fix load db models error #2290

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

fangyinc
Copy link
Collaborator

@fangyinc fangyinc commented Jan 9, 2025

Description

Ensure proper initialization of application modules and enhance the resource parameters handling for agent.

In this dbgpt/agent/resource/app.py#L34, the database is read in advance before it is initialized.

Closes #2184
Closes #2287
Closes #2163

How Has This Been Tested?

Clone a new DB-GPT project, run it with SQLite database.

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added agent Module: agent fix Bug fixes labels Jan 9, 2025
Copy link
Contributor

@cinjoseph cinjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit ddfb435 into eosphoros-ai:main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Module: agent fix Bug fixes
Projects
None yet
4 participants