-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): optimize of base agent #2276
base: main
Are you sure you want to change the base?
Conversation
… APP an Agent originates from in a cascading app scenario
6363145
to
e920421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+
ConversableAgent add name prefix, To confirm which APP an Agent originates from in a cascading app scenario。There are some questions about this modification. Agents can overload and define their own names. In theory, there is no need to add name processing including prefixes to the base class. |
@yhjun1026 I think the current design is based on the assumption that there is only one of each type of Agent within the same context. In my current scenario, one app can call another app, and if both apps contain the same type of Agent, I won't be able to distinguish which app an Agent comes from in places where the Agent name is displayed. I think that Agent names shouldn't be fixed or directly tied to their Roles. The Role only represents their species, but there are many different individuals within a species. It's like how we are all humans (Role), yet we have different names. |
@property | ||
def name(self) -> str: | ||
"""Return the name of the agent.""" | ||
if self.name_prefix is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is different to understand. Maybe it's better to use .
or -
such as:
Report.ChatReport
or Report-ChatReport
?
Description
How Has This Been Tested?
Snapshots:
Include snapshots for easier review.
Checklist: