fix(security): prevent SQL injection in chart data query (CVE-2024-10901) #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…901) - Add SQL validation for chart queries - Block dangerous DuckDB operations - Implement timeout protection - Enhance input validation and type safety
8 tasks
|
Thanks for your contribution. |
|
Hi @haawha , please format codes by |
Ths! It's done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a SQL injection vulnerability in the chart data query API that could allow attackers to perform arbitrary file operations through DuckDB SQL queries. This is related to CVE-2024-10835 and implements similar protections in the chart functionality.
Key changes:
How Has This Been Tested?
Snapshots:
Include snapshots for easier review.
Checklist: