Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve export model code #120

Merged
merged 2 commits into from
Nov 3, 2023
Merged

improve export model code #120

merged 2 commits into from
Nov 3, 2023

Conversation

zhanghy-sketchzh
Copy link
Collaborator

1.Update model_trainer.py

wangzaistone
wangzaistone reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@wangzaistone wangzaistone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你发现的这个导出文件时再如果更改了dataset_info.json中值后，会出现报错的情况这个挺好的，这个后面需要解耦，目前你的这个修复方式，你确定运行通过吗？担忧会影响其他模块。

@wangzaistone wangzaistone changed the title fix bug improve export model code Nov 3, 2023
wangzaistone
wangzaistone approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@wangzaistone wangzaistone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@wangzaistone wangzaistone merged commit fe90150 into main Nov 3, 2023
2 checks passed
@zhanghy-sketchzh zhanghy-sketchzh deleted the zhanghy-sketchzh-patch-2 branch November 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangzaistone wangzaistone wangzaistone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhanghy-sketchzh @wangzaistone