Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bios is now using zlog instead of a custom logger #152

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

billettc
Copy link
Contributor

bios is now using zlog instead of a custom logger
added Ops delegate bw and buy ram

added Ops delegate bw and buy ram
@billettc billettc requested a review from maoueh May 29, 2020 17:02
@maoueh
Copy link
Contributor

maoueh commented Jun 5, 2020

I'm not 100% sure about the move to zlog for user printed strings. I don't have any problem with having it for debugging logs, but it creates raw formatted output string to the user which IMO does not feel like a great experience.

I would like to discuss this with you to check what we could do to improve this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants