Refactor the addMailHeaders method

eoghanobrien · Feb 17, 2017 · 0fd0eb6 · 0fd0eb6
1 parent b826dc9
commit 0fd0eb6
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/class.simple_mail.php b/class.simple_mail.php
@@ -317,15 +317,12 @@ public function addMailHeaders($header, array $pairs)
                 'You must pass at least one name => email pair.'
             );
         }
+        $addresses = array();
         foreach ($pairs as $name => $email) {
-            if (is_numeric($name)) {
-                $addresses[] = $this->formatHeader($email);
-            } else {
-                $addresses[] = $this->formatHeader($email, $name);
-            }
+            $name = is_numeric($name) ? null : $name;
+            $addresses[] = $this->formatHeader($email, $name);
         }
-        $addresses = implode(',', $addresses);
-        $this->addGenericHeader($header, $addresses);
+        $this->addGenericHeader($header, implode(',', $addresses));
         return $this;
     }