Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue #40 #95

Closed
wants to merge 1 commit into from
Closed

fix the issue #40 #95

wants to merge 1 commit into from

Conversation

mjkohoh
Copy link
Contributor

@mjkohoh mjkohoh commented Oct 22, 2013

为继承了Fragment的每个类增加一个空的构造函数,以此避免产生的FC。之所以没有采用 @rockybean 的建议是因为添加newInstance方法相对而言改动稍大。并且在 #48 中采用了增加空构造函数的方法避免FC,如果采用增加newInstance方法会使项目有些冲突。

@feicien
Copy link
Contributor

feicien commented Oct 22, 2013

仅仅填加空构造方法是不行的,还要删掉那些非空构造方法。这样参数怎么传递呢?使用setArguments
2013年10月22日 下午9:15于 "KOHOH" [email protected]写道:

为继承了Fragment的每个类增加一个空的构造函数,以此避免产生的FC。之所以没有采用 @rockybeanhttps://github.com/rockybean的建议是因为添加newInstance方法相对而言改动稍大。并且在

#40 https://github.com/eoecn/android-app/issues/40中采用了增加空构造函数的方法避免FC,如果采用增加newInstance方法会使项目有些冲突。

You can merge this Pull Request by running

git pull https://github.com/KOHOH1992/android-app issue#40

Or view, comment on, or merge it at:

#95
Commit Summary

File Changes

  • M source/src/cn/eoe/app/view/UserCollectFragment.javahttps://github.com/fix the issue #40 #95/files#diff-0(5)
  • M source/src/cn/eoe/app/view/UserCollectListFragment.javahttps://github.com/fix the issue #40 #95/files#diff-1(4)
  • M source/src/cn/eoe/app/view/UserIntroFragment.javahttps://github.com/fix the issue #40 #95/files#diff-2(4)
  • M source/src/cn/eoe/app/view/UserLogOutFragment.javahttps://github.com/fix the issue #40 #95/files#diff-3(4)
  • M source/src/cn/eoe/app/view/WikiFragment.javahttps://github.com/fix the issue #40 #95/files#diff-4(4)

Patch Links:

@mjkohoh mjkohoh closed this Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants