Skip to content
This repository has been archived by the owner on Jul 7, 2019. It is now read-only.

Don't cast cas to uint. #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timwilkens
Copy link

Fixes issue described in https://github.com/enyim/EnyimMemcached/issues/162.

Cas values are 64 bits (https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L175) and should never be treated as uints.

@@ -20,7 +20,7 @@ IStoreOperation IOperationFactory.Store(StoreMode mode, string key, CacheItem va
if (cas == 0)
return new StoreOperation(mode, key, value, expires);

return new CasOperation(key, value, expires, (uint)cas);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does unit test is required for this change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants